[ansel] HEAD when adding a comment

Heath S. Hendrickson heath at outerspaceconsultants.com
Wed Nov 24 09:49:37 PST 2004



   Yup, I'm getting the same thing.  It posts the comment, but I also
get the error just above the new posting.

I also got this error when I was looking at the options for something
the other day, but didn't have time to trace it down.

The offending line is in this block:

           /* If using alternating row shading, work out correct
         * shade. */
        if ($this->getOption('alternate')) {
            $className .= 'item' . $this->_alt_count;
            $this->_alt_count = 1 - $this->_alt_count;
        }

   Here's a diff to framework/Tree/Tree/html.php that seems to clear
up the error, but I'm not sure it's the "best" way to fix it.

   Index: Tree/Tree/html.php
===================================================================
RCS file: /usr/local/horde/cvs/framework/Tree/Tree/html.php,v
retrieving revision 1.46
diff -u -r1.46 html.php
--- Tree/Tree/html.php  21 Nov 2004 06:56:34 -0000      1.46
+++ Tree/Tree/html.php  24 Nov 2004 17:46:21 -0000
@@ -215,6 +215,7 @@
      */
     function _buildLine($node_id)
     {
+        $className = '';
         if (!empty($this->_nodes[$node_id]['class'])) {
             $className = $this->_nodes[$node_id]['class'];
         }
heath

   P.S.  As an aside, I think that the deletion of comments needs to
be improved.  As is, it leaves the users in the Agora application
after deleting a comment with no obvious way to get back to Ansel. 
Perhaps an intermediary page within Ansel to delete the comment that
then calls the Agora delete function would be better?  That way the
user could be redirected back to the picture afterwards.

   Quoting Steve Daniels :

> Notice: Undefined variable: className in
> /home/stedan/pear_install/PEAR/Horde/Tree/html.php on line 224
>
> When adding a comment to a picture in a gallery.
>
> Any ideas?
>
> Thanks, Steve
> -- ansel mailing list - Join the hunt:
http://horde.org/bounties/#ansel
> Frequently Asked Questions: http://horde.org/faq/
> To unsubscribe, mail: ansel-unsubscribe at lists.horde.org
>



More information about the ansel mailing list