[Tickets #7831] Re: Special folder display with custom images broken in DIMP

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/7831
------------------------------------------------------------------------------
  Ticket             | 7831
  Updated By         | Gunnar Wrobel <p at rdus.de>
  Summary            | Special folder display with custom images broken in
                     | DIMP
  Queue              | DIMP
  Version            | HEAD
  Type               | Bug
  State              | Feedback
  Priority           | 1. Low
  Milestone          |
  Patch              |
  Owners             | Michael Slusarz
------------------------------------------------------------------------------


Gunnar Wrobel <p at rdus.de> (2009-02-09 10:58) wrote:

>> Works fine! I had to exchange the style name 'background-image'
>> against 'backgroundImage' in dimp/js/DimpBase.js though.
>
> That is not correct.  From prototypejs API docs:
>
> setStyle(element, styles) -> HTMLElementModifies element’s CSS style  
> properties. Styles are passed as a hash of property-value pairs in  
> which the properties are specified in their **camelized** form.
>
> This is because this code:
> { background-image: foo }
>
> isn't valid javascript (you can't have dashes in Object property names).

I'm confused now. When I applied your patch to the current  
horde-webmail release I got a JavaScript error and I assume the reason  
was that it was indeed invalid JavaScript.

I'm still not very used to JavaScript and have no clue about prototype  
either. I basically googled for the fix I described in my earlier  
comment. So I don't know if it is valid or not.

 From your comment I don't understand if I should use  
'background-image' though. Using 'backgroundImage' as the argument  
works fine on my side and gets turned into the correct  
'background-image' attribute on the client.

Your comment does not directly invalidate this, does it? So what  
should I check on my side?