[Tickets #8323] Re: Use streams for ssh2 driver in VFS

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/8323
------------------------------------------------------------------------------
  Ticket             | 8323
  Updated By         | Jan Schneider <jan at horde.org>
-Summary            | Down- and upload over SSH2 partially broken
+Summary            | Use streams for ssh2 driver in VFS
  Queue              | Horde Framework Packages
  Version            | HEAD
  Type               | Enhancement
-State              | New
+State              | Feedback
  Priority           | 1. Low
  Milestone          |
  Patch              |
  Owners             |
------------------------------------------------------------------------------


Jan Schneider <jan at horde.org> (2009-06-05 03:19) wrote:

If you are already using streams, why do you read the complete file  
contents into memory instead of using copy()? You could even replace  
VFS' copy and move functionality completely by the native PHP calls.
Also, please review your patch reading the Horde coding standards  
(single quotes, lowercase keywords). And if you want the patch to also  
be applied to the stable branch, you need a fallback if  
file_put_contents() doesn't exist (PHP 5 only).