[dev] [cvs] commit: turba/lib Driver.php api.php turba/lib/Driver sql.php

[Jan Schneider]

Zitat von Michael Rubinsky <mike at theupstairsroom.com>:

> Quoting Jan Schneider <jan at horde.org>:
>
>> jan         2007-10-29 11:21:28 EDT
>>
>>   Modified files:
>>     lib                  Driver.php api.php
>>     lib/Driver           sql.php
>>   Log:
>>   Catch errors.
>>   Fix query generation.
>>   Use ANSI SQL (works fine with DATE columns in MySQL too btw).
>>   Simplify code.
>
>
> I was under the impression that not all RDBMS actually implemented the
> ANSI version of the substring() command.  In particular (at least some
> versions of) MS SQL implement it in the (string, from, to) kind of way.

That sucks. Does that mean that not all RDMBS implement the ANSI  
version, but all implement a non-standard version that works  
everywhere the same? I wonder what standards are for.

> Also, I used the $params parameter to _getTimeObjectTurbaList() to
> more easily facilitate additional time objects to be returned.  I know
> there is at least one ticket for returning Anniversary dates as well...

You can always add more function arguments when necessary. There is no  
advantage in passing a hash, it's a private function anyway.

Jan.

-- 
Do you need professional PHP or Horde consulting?
http://horde.org/consulting/