[dev] [commits] Horde branch master updated. d3a3a8ba4f403b2c05c0573ca519b7e349a8c657

Michael M Slusarz slusarz at horde.org
Wed Jul 15 04:53:48 UTC 2009


On Tue, 2009-07-14 at 23:27 -0400, Chuck Hagenbuch wrote:
> Quoting Chuck Hagenbuch <chuck at horde.org>:
> 
> >> I don't think it's good practice to use exceptions for anything but  
> >> throwing. Beside that, wrapping in a class when we need the  
> >> different parts (message, file, line) later anyway, is unnecessary  
> >> IMO.
> >
> > I agree. Also, if the goal is to get rid of __FILE__ and __LINE__ (a  
> > good goal), we can just use debug_backtrace() to get that.
> 
> One step further - Horde::fatal() shouldn't be necessary at all. It  
> should be replaced by the last-ditch global exception handler I  
> mentioned earlier - any uncaught exception ends up triggering a fatal  
> anyway. They should be the same thing.

I may have missed the previous discussion, but I already added a
last-ditch global exception handler (in lib/core.php).  It currently
calls Horde::fatal().

michael



More information about the dev mailing list