[dev] Send event reminders and daily agendas for different domains

Jan Schneider jan at horde.org
Tue May 31 15:05:41 UTC 2011


Zitat von Gonçalo Queirós <goncalo.queiros at portugalmail.net>:

> On 05/25/2011 03:00 PM, Gonçalo Queirós wrote:
>>
>> On 05/25/2011 02:48 PM, Gonçalo Queirós wrote:
>>>> Yes, this is the right direction. I would strip cli_ from the option
>>>> name though, because it could potentially be users for different
>>>> things than CLI scripts. And I would rather use an environment
>>>> variable (SERVER_NAME) than a command line argument for the actual
>>>> script, because you can run several several scripts under the same
>>>> environment, or one script under several environments, without
>>>> changing the script calls. Finally, this should of course be used by
>>>> all CLI scripts.
>>>>
>>>> Jan.
>>>>
>>> If i set the SERVER_NAME environment variable, then the scripts from CLI
>>> wouldn't run because they would fail on Horde_Cli::runningFromCLI(),
>>> that's why i used a command line argument.
>>>
>> Nvm this..i didn't interpreted this as "shell environment variable"
>>
>
> Fixed the previous patch proposal.
> What do you think Jan?

Looks good.

Jan.

-- 
Do you need professional PHP or Horde consulting?
http://horde.org/consulting/



More information about the dev mailing list