[dev] horde/timezone unit tests: Pass on PHP 7.4, fail on PHP 8

Michael J Rubinsky mrubinsk at horde.org
Sun Nov 6 18:01:48 UTC 2022


Quoting Ralf Lang <ralf.lang at ralf-lang.de>:

> See
>
> https://github.com/maintaina-com/Timezone/actions/runs/3399648494/jobs/5653535832
>
> The unit tests present diverging output in 4 cases on PHP 8 but are  
> fine in PHP 7.4 - I am not very familiar with the package. It might  
> be that the unit test fixtures are simply no longer in line with  
> revised national laws.
>
> Any suggestions?

IIRC, the way those tests work is to load a stanza of the Olson tz  
database from the fixtures folder and compare it to the already  
generated ics in the same fixtures folder. From the failure diff you  
provided it looks like you are using different fixtures from what are  
in upstream master?


> -- 
> dev mailing list
> Frequently Asked Questions: http://wiki.horde.org/FAQ
> To unsubscribe, mail: dev-unsubscribe at lists.horde.org



-- 
mike
The Horde Project
http://www.horde.org
https://www.facebook.com/hordeproject
https://www.twitter.com/hordeproject
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-keys
Size: 9386 bytes
Desc: PGP Public Key
URL: <https://lists.horde.org/archives/dev/attachments/20221106/7e879491/attachment.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 851 bytes
Desc: PGP Digital Signature
URL: <https://lists.horde.org/archives/dev/attachments/20221106/7e879491/attachment.sig>


More information about the dev mailing list