[horde] Using hooks to permanently set from_addr and fullname

[Michael M Slusarz]

Quoting Chuck Hagenbuch <chuck at horde.org>:

> Quoting Kevin Myer <kevin_myer at iu13.org>:
>
>>> Are you sure this is from preferences hooks? The check on line 707 of
>>> Prefs.php:
>>>
>>>        if (!is_null($this->_hooksCalled) && !Auth::getAuth()) {
>>>            return;
>>>        }
>>>
>>> ... looks suspicious to me - should that be && Auth::getAuth(), instead
>>> of ! ? Anyone?
>>
>> Ok, from a calltrace of an import of a single event into a calendar,
>> that is the critical point that is generating all the directory
>> server connections.  I
>> changed !Auth::getAuth() to Auth::getAuth() and no extra connections were
>> created.  I'm importing a 200Kb event file now, which normally
>
> Michael, you introduced the !Auth::getAuth() in rev. 1.88 of Prefs.php.
> Can you explain the reason for that check? I can't see a reason for it
> to be there, and it seems like it should be Auth::getAuth() instead of
> !Auth::getAuth() at least.

Looks like I did something in 1.88 that I reverted in 1.89 - except I 
missed 2 lines of code:
http://cvs.horde.org/diff.php/framework/Prefs/Prefs.php?ws=0&r1=1.87&r2=1.89&ty=u

So I am almost 100% sure that it should not be there and I will remove it.

michael

_______________________________________
Michael Slusarz [slusarz at curecanti.org]