[imp] redirect bug

Payton payton at repligen.com
Mon Jan 5 10:02:01 PST 2004


This is in reference to my eariler post ("redirect bug?"). I tracked down 
the cause of my problem, and have attached a patch which would solve it, 
but I'm not sure that I'm solving it the right way.
	The problem in summary is that when logging into horde, and
setting imp to be the first application displayed (with the frameset
enabled), and setting imp to use horde auth, the horde frameset is 
displayed twice.  
	I discovered that this is caused around line 139 of
imp/redirect.php, where the full horde url is prepended to the imp url 
before redirecting. If the imp url is used instead, this problem does not 
occur. I'm not familiar enough with the imp redirect to know how to 
properly compromise between these two situations (the problem does not 
exist if using imp auth).

-Payton
-------------- next part --------------
*** redirect.php	2004-01-05 12:47:49.000000000 -0500
--- redirect.php.works	2004-01-05 12:48:58.000000000 -0500
*************** if ((!is_null($imapuser) && !is_null($pa
*** 136,142 ****
          $full_url = Horde::applicationUrl($registry->getParam('webroot', 'horde') . '/index.php', true);
          $full_url = Util::addParameter($full_url, 'url', $url);
  
!         header('Location: ' . $full_url);
          exit;
      } else {
          $url = Horde::applicationUrl(IMP::logoutUrl('login.php', 'failed'), true);
--- 136,142 ----
          $full_url = Horde::applicationUrl($registry->getParam('webroot', 'horde') . '/index.php', true);
          $full_url = Util::addParameter($full_url, 'url', $url);
  
!         header('Location: ' . $url);
          exit;
      } else {
          $url = Horde::applicationUrl(IMP::logoutUrl('login.php', 'failed'), true);


More information about the imp mailing list