[Bug 492] Changed - Javascript error due to an small typo in imp-2.2.3/locale/fr/message.lang
bugs@bugs.horde.org
bugs@bugs.horde.org
Tue, 10 Oct 2000 13:16:45 -0300
http://bugs.horde.org/show_bug.cgi?id=492
*** shadow/492 Tue Oct 10 12:49:59 2000
--- shadow/492.tmp.31380 Tue Oct 10 13:16:45 2000
***************
*** 3,10 ****
Version: 2.2 Stable
Platform: Netscape 4.5
OS/Version: All
! Status: ASSIGNED
! Resolution:
Severity: trivial
Priority: P4
Component: IMP
--- 3,10 ----
Version: 2.2 Stable
Platform: Netscape 4.5
OS/Version: All
! Status: RESOLVED
! Resolution: FIXED
Severity: trivial
Priority: P4
Component: IMP
***************
*** 43,45 ****
--- 43,81 ----
------- Additional Comments From chuck@horde.org 10/10/00 12:49 -------
sounds right to me.
+
+ ------- Additional Comments From bjn@horde.org 10/10/00 13:16 -------
+ Oops, it was line 75 (387 total lines in the file). :-) OK, I've committed the
+ fix to supply the missing addslashes(). I can't attach files to bugs in this
+ version of Bugzilla, and I don't know if this patch will survive, but get it
+ from CVS if not. Let us know if that solves the problem. Thanks!
+
+ Index: message.php3
+ ===================================================================
+ RCS file: /cvs/horde/imp/Attic/message.php3,v
+ retrieving revision 2.23.2.61
+ diff -u -r2.23.2.61 message.php3
+ --- message.php3 2000/09/21 09:32:13 2.23.2.61
+ +++ message.php3 2000/10/10 16:08:56
+ @@ -72,7 +72,7 @@
+ $string .= 'onMouseOver="status=\'' . $lang->compose . '\';
+ return true;" onMouseOut="status=\'\';">' . htmlSpecialChars($addr) . '</a>';
+
+ if ($default->user_use_addressbook && $default->use_db) {
+ - $string .= '<a onMouseOver="status=\'' .
+ addslashes($lang->add_to_contacts) . '\'; return true;"
+ onMouseOut="status=\'\';" href="javascript:open_add_contact_win(\'actionID=' .
+ ADD_CONTACT_OBJECT . '&object=' . urlencode(serialize((array)$ob)) . '\');">' .
+ '<img src="' . $default->graphics_url . '/addressbook-' . $color . '.gif"
+ border=0 align="absmiddle" hspace=2 alt="' . $lang->add_to_contacts . '"></a>';
+ + $string .= '<a onMouseOver="status=\'' .
+ addslashes($lang->add_to_contacts) . '\'; return true;"
+ onMouseOut="status=\'\';" href="javascript:open_add_contact_win(\'actionID=' .
+ ADD_CONTACT_OBJECT . '&object=' . urlencode(serialize((array)$ob)) . '\');">' .
+ '<img src="' . $default->graphics_url . '/addressbook-' . $color . '.gif"
+ border=0 align="absmiddle" hspace=2 alt="' . addslashes($lang->add_to_contacts)
+ . '"></a>';
+ }
+
+ } // end while
+