[bugs] [Bug 1008] New - Modul chora: Annotation fails with internal server error

[bugs@bugs.horde.org]

http://bugs.horde.org/show_bug.cgi?id=1008

*** shadow/1008	Tue Jul 30 06:09:36 2002
--- shadow/1008.tmp.24441	Tue Jul 30 06:09:36 2002
***************
*** 0 ****
--- 1,57 ----
+ Bug#: 1008
+ Product: Horde
+ Version: 2.2 Stable
+ Platform: PHP Code
+ OS/Version: Linux
+ Status: NEW   
+ Resolution: 
+ Severity: normal
+ Priority: P2
+ Component: Core
+ Area: BUILD
+ AssignedTo: chuck@horde.org                            
+ ReportedBy: markus.ruth@rrc-ps.de               
+ URL: 
+ Summary: Modul chora: Annotation fails with internal server error
+ 
+ Modul chora:
+ ============
+ 
+ - Annotation (even textual files!) fails with internal server error.
+ 
+ in file lib/CVSLib/Aannotate.php about line 83
+ 
+    if (!preg_match("|^E\s+Annotations for $where|", $line)) {
+       return new CVSLib_Error(CVSLIB_INTERNAL_ERROR, "Unable to annotate; 
+ server said: $line");
+    }
+ 
+ produces failure, because the generated annotation file has first line with
+ a signle "E" followed by newline. The command fgets( ... ) to read first part 
+ of file reads just the first line!
+ Program "rlog -V" shows "RCS version 5.7
+ 
+ Solution: you should scan at least first three lines after the expression.
+ This is what my system (SuSE Linux 7.1) generates as rlog output file:
+ 
+ E 
+ E Annotations for ST6/delay.asm
+ E ***************
+ M 1.1          (mruth    29-Jul-02): 
+ M 1.1          (mruth    29-Jul-02): 				.DISPLAY " 
+ DELAY "
+ M 1.1          (mruth    29-Jul-02): 				.EJECT		
+ 				; generate a new page in the output listing. 
+ M 1.1          (mruth    29-Jul-02): 
+ M 1.1          (mruth    29-Jul-02): ;  ----------------------------------------
+ ----------------------------------------------------------
+ M 1.1          (mruth    29-Jul-02): ;
+ M 1.1          (mruth    29-Jul-02): ;  DELAY Bibliothek  
+ M 1.1          (mruth    29-Jul-02): ; 
+ 
+ ...
+ 
+ 
+ Hope I could support you a bit.
+ Your frame - WORK - is a very fine pice of code !
+