[bugs] [Bug 1156] Changed - wrong content type in css.php.

bugs at bugs.horde.org bugs at bugs.horde.org
Wed Feb 5 20:44:32 PST 2003


http://bugs.horde.org/show_bug.cgi?id=1156

*** shadow/1156	Wed Feb  5 19:53:40 2003
--- shadow/1156.tmp.26035	Wed Feb  5 20:44:32 2003
***************
*** 110,112 ****
--- 110,144 ----
  the latest versions that's NOT marked as being supported only experimental with PHP.
  
  Secondly, if it's a one line fix, why don't you just submit a patch?
+ 
+ ------- Additional Comments From tlb at rapanden.dk  02/05/03 20:44 -------
+ I did not mean to be impolite, but it would be nice if you could be more
+ informativ in the future about the status of a bug fix being committed. As i did
+ not know if you did not think I had proven that this problem existed or this was
+ the correct fix. Just to clarify, what was wrong with the first fix/bug rapport?
+ 
+ With further testing has shown that PHP 4.2.3 and at least 1.3.26 has this
+ problem, I have submitted a bug rapport to PHP. But it's still more correct to
+ print the full Content-Type with charset defined as it's will be ISO-8859-1 if
+ not defined.
+ 
+ Her you can see that this encoding is valid:
+ 
+ http://www.ietf.org/rfc/rfc2318.txt
+ 
+ 
+ Patch provided her:
+ 
+ --- css.php.old     2003-02-06 01:10:15.000000000 +0100
+ +++ css.php 2003-02-06 01:11:29.000000000 +0100
+ @@ -73,7 +73,7 @@
+          header('Pragma: no-cache');
+          header('Cache-Control: no-store, no-cache, must-revalidate,
+ post-check=0, pre-check=0');
+      }
+ -    header('Content-Type: text/css');
+ +    header('Content-Type: text/css; charset=ISO-8859-1');
+  }
+ 
+  if (is_array($css)) {
+ 


More information about the bugs mailing list