[bugs] [Bug 1181] New -

[bugs at bugs.horde.org]

http://bugs.horde.org/show_bug.cgi?id=1181

*** shadow/1181	Thu Feb 20 17:48:35 2003
--- shadow/1181.tmp.8267	Thu Feb 20 17:48:35 2003
***************
*** 0 ****
--- 1,51 ----
+ Bug#: 1181
+ Product: Horde
+ Version: 2.2 Stable
+ Platform: PHP Code
+ OS/Version: All
+ Status: NEW   
+ Resolution: 
+ Severity: normal
+ Priority: P2
+ Component: Core
+ Area: BUILD
+ AssignedTo: chuck at horde.org                            
+ ReportedBy: matt at xrefer.com               
+ URL: 
+ Summary: 
+ 
+ I've recently upgraded to Horde 2.2.1 from 2.1 and I was making use of the
+ use_ssl=1 setting to always auto-generate https://... urls.
+ 
+ The following code in lib/Horde.php seems to have broken this functionality:
+ 
+             /* If using non-standard ports, add the port to the URL. */
+             if ((($protocol == 'http') && ($server_port != 80)) ||
+                 (($protocol == 'https') && ($server_port != 443))) {
+                 $server_name .= ':' . $server_port;
+             }
+ 
+ ...in that attempting to view an http://... url, (such as a new user going to
+ http://webmail.somewhere.com/), gets a redirect url being generated of the form:
+ 
+ https://webmail.somewhere.com:80/...
+ 
+ ...because the current server port is 80, but the protocol has been set to https
+ higher up in the function, so the above conditional statement forces the :80 to
+ be incorrectly added.
+ 
+ I think the code should check the use_ssl to adjust its logic slightly.
+ 
+ For the time being, I have copied the code from horde 2.1:
+ 
+             if ($server_port != 80 && $server_port != 443) {
+                 $server_name .= ':' . $server_port;
+             }
+ 
+ ...and commented out the troublesome code, which while not great if I ever ran
+ the webserver on non-standard ports, works enough for me here.
+ 
+ Cheers
+ 
+ Matt
+