[Tickets #551] Forwards LDAP driver

bugs at bugs.horde.org bugs at bugs.horde.org
Tue Sep 7 19:25:27 PDT 2004


DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=551
-----------------------------------------------------------------------
 Ticket     | 551
 Updated By | url-horde-tickets at freed.com
 Summary    | Forwards LDAP driver
 Queue      | Forwards
 Version    | RELENG_2
 State      | Assigned
 Priority   | 2. Medium
 Type       | Bug
 Owners     | Horde Developers
-----------------------------------------------------------------------


url-horde-tickets at freed.com (2004-09-07 19:25) wrote:

>please take a read through horde/docs/CODING_STANDARDS.

I did -- and I also tried hard to copy the coding conventions from the
"neighboring" code.  But I can easily believe that I missed or forgot
something.   I will re-read the doc and review my code.  In the meantime, is
there some particular blunder that you caught?

The only intentional exceptions were the "// :ptf:" notes -- and these were
designed to be excised from the production code.  That's why I tagged them
with a string that's easy to find.  I only put them in to make a complex
patch easier to review.

> Second, there's no need for
>   :Forwards_Driver_ldap - 
> it doesn't do anything different from the parent
> function that it automatically inherits.

I would have thought so -- but that doesn't appear to be the case.  Again, I
might have missed something, but there's that annoying empirical evidence: 
If you comment out that function, the module fails.





More information about the bugs mailing list