[Tickets #657] HTML editing broken if services/editor not a subdirectory of Horde webroot

[bugs at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=657
-----------------------------------------------------------------------
 Ticket     | 657
 Updated By | Jan Schneider <jan at horde.org>
 Summary    | HTML editing broken if services/editor not a subdirectory of Horde webroot
 Queue      | IMP
 Version    | 4.0-ALPHA
 State      | Feedback
 Priority   | 1. Low
 Type       | Bug
 Owners     | Horde Developers
-----------------------------------------------------------------------


Jan Schneider <jan at horde.org> (2004-10-10 02:37) wrote:

>> *) lib/Horde/Editor/htmlarea.php, lines 28 & 29, what's that about?
>
> I have absolutely no idea what that's for. Jan, Marko?

The first call includes templates/javascript/htmlarea.js, parsed through
services/javascript.php. This one sets the base URL of the HTMLArea editor.
The editor needs this URL to find all its scripts, images and CSS files. We
pass it through javascript.php because the path depends on the 'webroot'
setting.
Maybe you can relocate the htmlarea scripts by only changing this file.

The second call uses the capability of Horde::addScriptFile() to create
<script> tags *without* parsing the script files throug javascript.php. It
includes the basic JS file for the HTMLArea editor. This is the action that
any client needs to take that wants to use this editor. This way to call
addScriptFile() also requires the 'webroot' setting, not at call-time but
when Horde::includeScriptFiles() actually renders the <script> tags.

This is the only way to keep the htmlarea code separate from the Horde code
and keep it updateable without needing to patch the code each time.