[Tickets #606] Typecasting required in whups/lib/Driver/sql.php on Oracle

[bugs at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=606
-----------------------------------------------------------------------
 Ticket     | 606
 Updated By | rvs at angara.ru
 Summary    | Typecasting required in whups/lib/Driver/sql.php on Oracle
 Queue      | Whups
 State      | Assigned
 Priority   | 2. Medium
 Type       | Bug
 Owners     | Chuck Hagenbuch
+Attachment | upgrade.php
-----------------------------------------------------------------------


rvs at angara.ru (2004-11-17 09:15) wrote:

Okay I've returned back and fixed this issue.
The solution I enclose contains of:
1. adding LOG_VALUE_NUM field of integer type to WHUPS_LOGS table
2. creating index on LOG_VALUE_NUM for fast JOIN's
3. filling LOG_VALUE_NUM field with numbers from LOG_VALUE field
4. fixing whups/lib/Driver/sql.php code to use LOG_VALUE_NUM in JOIN's,
cross-type comparisons
5. fixing whups/lib/Driver/sql.php code to insert corresponding value into
LOG_VALUE_NUM together with LOG_VALUE.

The upgrade.php script does 1,2,3 and driversql.patch does 4,5.
Note that upgrade.php script pretends to be database-portable, no
Oracle-specific stuff is used, SQL operators are ANSI-compliant.