[Tickets #1291] Folder dropdown sorted incorrectly

[bugs at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=1291
-----------------------------------------------------------------------
 Ticket     | 1291
 Updated By | alex at milivojevic.org
 Summary    | Folder dropdown sorted incorrectly
 Queue      | IMP
 Version    | 4.0.1
 State      | Assigned
 Priority   | 1. Low
 Type       | Bug
 Owners     | Michael Slusarz
+Attachment | folder_dropdown.patch
-----------------------------------------------------------------------


alex at milivojevic.org (2005-02-03 10:17) wrote:

The bug is in _mbox_cmp function in horde-3.0.2/lib/Horde/IMAP/Sort.php. 
When sorting, it checks only if one of the arguments is INBOX itself. 
Folders that are subfolders of INBOX are sorted just like any other folders
(ignoring _sortinbox setting).

The attached patch fixes this.  Even when using namespace or similar
options, this should be good thing to do.  Sorted list will contain INBOX,
than subfolders of INBOX (with INBOX. part displayed or hidden, depending on
used options), and than all other folders.  In some cases, this might result
in the folder list that might not look completely sorted on the first look,
but it will be more logical (because user's folders will not be mixed with
shared or other users folders).