[Tickets #1257] Incomplete Thread View

[bugs at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=1257
-----------------------------------------------------------------------
 Ticket     | 1257
 Updated By | Michael Slusarz <slusarz at mail.curecanti.org>
 Summary    | Incomplete Thread View
 Queue      | IMP
 Version    | 4.0.1
 State      | Assigned
 Priority   | 1. Low
 Type       | Bug
 Owners     | Michael Slusarz
-----------------------------------------------------------------------


Michael Slusarz <slusarz at mail.curecanti.org> (2005-02-10 19:52) wrote:

This patch makes no sense.  First, why are you changing the return value of
getKey from false to null?  That doesn't get you anywhere.  Second, why are
you using ++$key instead of $key++?  You are missing a whole potential case
by doing this.  Third, if ($this->_thread[$key]) doesn't exist, you have a
mailbox that is corrupt - that code should never be reached or else there
are issues elsewhere.  So it makes a whole bunch of sense to exit the loop
rather than ignore the entry - which may lead to some very weird output.