[Tickets #1257] Incomplete Thread View

[bugs at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=1257
-----------------------------------------------------------------------
 Ticket             | 1257
 Updated By         | Michael Slusarz <slusarz at mail.curecanti.org>
 Summary            | Incomplete Thread View
 Queue              | IMP
 Version            | 4.0.1
 State              | Feedback
 Priority           | 1. Low
 Type               | Bug
 Owners             | Michael Slusarz
-----------------------------------------------------------------------


Michael Slusarz <slusarz at mail.curecanti.org> (2005-02-15 23:50) wrote:

Response from K-team:
Sorry, I thought it was clear....you just have to send a mail from an
empty mailbox and reply a couple of times, so that you have a thread.
if you sort the mailbox by thread it seems good, but when you read a
message from the thread, if you click on "View Thread" it shows just
the message you were reading. After investigating a while I noticed
that _getKey sometimes returns key=0 for the first mail in thread. in
getThreadBase this test:
 if ($key = $this->_getKey($index))
fails if $key is 0, so I modifyed it in
 $key = $this->_getKey($index); + if (isset($key))
and set return value to null in _getKey when it fails.
I also changed $key++ to ++$key for the same reason, the while loop
breaks soon if $key is 0.
As far as regards the third point, I've run into a situation in which
a deleted message breaks the thread and it displays nothing, so
thought it was better to end the cycle and just skip the message.

Hope it's clearer now
 K-team