[Tickets #1434] phishing warning

[bugs at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=1434
-----------------------------------------------------------------------
 Ticket             | 1434
 Updated By         | Jan Schneider <jan at horde.org>
 Summary            | phishing warning
 Queue              | IMP
 Version            | HEAD
-State              | Accepted
+State              | Feedback
 Priority           | 1. Low
 Type               | Enhancement
 Owners             | 
-----------------------------------------------------------------------


Jan Schneider <jan at horde.org> (2005-02-28 06:36) wrote:

This looks good as a first glance. I have some suggestions though:

- In the first two preg_match calls, why do you expect a whitespace like
'href= http://...' if the href attribute is *not* enclosed in quotes? |\s+
should probably be |\s*
- You should use MIME_Contents::formatStatusMessage() for showing the
phishing warnings, see imp/lib/MIME/Viewer/html.php for examples. It might
also be a good thing to extend this method to also accept an optional class
name for the status box. That wouldn't break BC and allows to show boxes
that look more like warnings like the current ones that even have a fixed
style.
- The message could probably be tweaked to sound less diffuse. But that
could be done later. But at least it has to be a gettext message.