[Tickets #1662] Turba sort of search results and browse by many criteria

[bugs@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=1662
-----------------------------------------------------------------------
 Ticket             | 1662
 Updated By         | br at absb.de
 Summary            | Turba sort of search results and browse by many criteria
 Queue              | Turba
 Version            | HEAD
 State              | Feedback
 Priority           | 2. Medium
 Type               | Enhancement
 Owners             | 
-----------------------------------------------------------------------


br at absb.de (2005-05-25 19:30) wrote:

> 1. You need to read horde/docs/CODING_STANDARDS

Wheres the exact problem? Besides a little short doc and some non-wrapped
lines?

> 2. The patch is out of date with CVS now and needs to be updated.

Can be done.

> 3. I don't see any place to affect more than the primary sort field

The new functionality shows up when you click on a second header. It takes
over the main sort column and the previously selected ones act as secondary
sort columns.

> though that could just be the lack of comments in whatever is going on at
the top of browse.php in the "Evaluate Sorting" block.

The "Evaluate sorting" block updates an internal Array which holds the sort
information. The sort info is stored in the $_SESSION. The array structure
should be documented.

> 4. Why did you add multisort() instead of making sort() aware of multiple
sort fields?

Because sort() and multisort() are two different procedures. sort could be
converted to a wrapper of multisort though.

> 5. If all this work is being done it's a shame not to use *any* of the
driver work for sorting, even if we can't do it for lastname sorts.

sort() itself doesn't utilize the driver either, as far as I see it so I
didn't try to implement it.