[Tickets #2245] Horde Share implementation for Turba

[bugs@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: https://dev.horde.org/horde/whups/ticket/?id=2245
-----------------------------------------------------------------------
 Ticket             | 2245
 Updated By         | kevin_myer at iu13.org
 Summary            | Horde Share implementation for Turba
 Queue              | Turba
 Version            | HEAD
 State              | Feedback
 Priority           | 1. Low
 Type               | Enhancement
 Owners             | Michael Rubinsky
-----------------------------------------------------------------------


kevin_myer at iu13.org (2005-07-17 15:14) wrote:

> I added the UI to edit the shares under the addressbook option 
> settings.  This can obviously be changed if there is a better place 
> for this.  I also  haven't implemented adding completly new shares 
> yet, as I wanted to get feedback on this before I continued further.

Just my opinion - it should be located in the same place as My {Calendars,
Notes, Tasks}, for consistency.

> Let me know what you think...I'm sure the code could be cleaned up a 
> bit, but I wanted to get feedback before spending much more time on 
> it ;)

Just two minor items:

lib/base.php contains an undefined reference to $result - I'm assuming
something like the following was intentioned:

--- base.php.bak        Sun Jul 17 18:11:27 2005
+++ base.php    Sun Jul 17 18:12:02 2005
@@ -48,9 +48,9 @@
 require TURBA_BASE . '/config/sources.php';

 // Check for any shares we have access to.
-$result = $GLOBALS['cfgSources'] =
Turba::getConfigFromShares($cfgSources);
-if (is_a($result, 'PEAR_Error')) {
-    $notification->push($result);
+$GLOBALS['cfgSources'] = Turba::getConfigFromShares($cfgSources);
+if (is_a($GLOBALS['cfgSources'], 'PEAR_Error')) {
+    $notification->push($GLOBALS['cfgSources']);
 }

 $GLOBALS['cfgSources'] = Turba::permissionsFilter($GLOBALS['cfgSources'],
'source');

Also, where I previously had two shares (My Addressbook -> localsql, Shared
Directory -> ldap), I now have three (including a new Kevin M. Myer's
Addressbook).  Not sure if that is an uninentional side effect or not.