[Tickets #2245] Horde Share implementation for Turba

[bugs@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: https://dev.horde.org/horde/whups/ticket/?id=2245
-----------------------------------------------------------------------
 Ticket             | 2245
 Updated By         | Michael Rubinsky <mrubinsk at horde.org>
 Summary            | Horde Share implementation for Turba
 Queue              | Turba
 Version            | HEAD
 State              | Feedback
 Priority           | 1. Low
 Type               | Enhancement
 Owners             | Michael Rubinsky
-----------------------------------------------------------------------


Michael Rubinsky <mrubinsk at horde.org> (2005-07-17 18:51) wrote:

> Just my opinion - it should be located in the same place as My 
> {Calendars, Notes, Tasks}, for consistency.

Yeah, your probably right...I'll move it over when it's more complete.  It
was just easier for me to plop it into the options to get it up and running
quicker...

> Just two minor items:
>
> lib/base.php contains an undefined reference to $result - I'm 
> assuming something like the following was intentioned:

Yep, thanks.  Actually, the error checking there isn't even necessary.  That
code was left over from an earlier implementation I was trying. 
Turba::getConfigFromShares takes care of the error checking and
$notification->push() - and will always return a cfgSources array...even if
it's just the original one that was passed in.

> Also, where I previously had two shares (My Addressbook -> localsql, 
> Shared Directory -> ldap), I now have three (including a new Kevin M. 
> Myer's Addressbook).  Not sure if that is an uninentional side effect 
> or not.

I'm not exactly sure what your saying here.  The share code wouldn't have
created an LDAP share.  Where are you seeing these three shares?

In a nutshell, what  should happen is this - When sources.php loads, it
checks if there is a share called 'localsql:kmyer' if it is not there, it is
created and given the title "Kevin M. Myer's Addressbook", along with
appropriate owner permissions.  This represents the same source that's in
$cfgSources['localsql'].  When a user is logged in, this 'localsql'
addressbook will be displayed to them as "My Addressbook" - since that's
what it is and that's probably what they are used to seeing it called.

If you decide to give me access to your "My Addressbook", then turba will
see that I have access to a share called 'localsql:kmyer', it will then
create a $cfgSources['localsql:kmyer'] entry with the appropriate
information.  When the address books are displayed, your address book will
be shown to me as "Kevin M. Myer's Addressbook" while my own address book
will be shown to me as "My Addressbook".  If I also had an LDAP source
configured, I would see three addressbooks, "My Addressbook", "Kevin M.
Myer's Addressbook", and "Some LDAP Directory".  If you were logged in and
did not have rights to any other user's address book, then you should only
see the two sources - "My Addressbook", and "Some LDAP Directory".