[Tickets #2121] RESOLVED: national characters absolutely bad with cyrus sieve

[bugs@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=2121
-----------------------------------------------------------------------
 Ticket             | 2121
 Updated By         | risko at risko.hu
 Summary            | national characters absolutely bad with cyrus sieve
 Queue              | Ingo
 Version            | 1.0.1
 State              | Resolved
 Priority           | 2. Medium
 Type               | Bug
 Owners             | Jan Schneider
+New Attachment     | ingo-sieve-comment-utf8.patch
-----------------------------------------------------------------------


risko at risko.hu (2005-07-24 17:02) wrote:

> Isn't that a problem, that Horde/String.php never require_once'd in 

No it isn't, I know now :)

Anyway, now I read your coding_standards document (better lately, than
never) and I found, that I should use include_once, so I fix this in this
patch.

A bigger fix is utf8'ized comments, since it is very annoying if you can't
pipe the generated output to a 'recode UTF-8..ISO-8859-2' as a system
administrator because of ISO-8859-2 comments (which are invalid UTF-8
characters).

Anyway, I think, that it is not a good idea to have localized comments in a
generated config file.  System administrators know english well enough and
if someone is doing some shell magic based on english comments it can be a
bg surprise that he has got non-english users with localized chinese
autocommented sieve data... :)

So _() should be removed from around comment strings which will go to sieve
scripts, I think.

Thanks,
Gergely