[Tickets #1060] moving rules

bugs@bugs.horde.org bugs at bugs.horde.org
Mon Jul 25 01:07:31 PDT 2005


DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=1060
-----------------------------------------------------------------------
 Ticket             | 1060
 Updated By         | Jan Schneider <jan at horde.org>
 Summary            | moving rules
 Queue              | Ingo
 Version            | 1.0
-State              | Assigned
+State              | Feedback
 Priority           | 1. Low
 Type               | Enhancement
 Owners             | 
-----------------------------------------------------------------------


Jan Schneider <jan at horde.org> (2005-07-25 01:07) wrote:

Looks fine so far, but I have severaly comments/suggestions:

- Don't use a POST submit, but a document.location redirection.
- Use the rule_up/rule_down actions, just add an optional offset. You can do
the calculation with JavaScript.
- in ruleUp()/ruleDown() merge the while() test into the for() test.
- Move the JavaScript to a separate function in filters/header.inc.




More information about the bugs mailing list