[Tickets #2245] Horde Share implementation for Turba

[bugs@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: https://dev.horde.org/horde/whups/ticket/?id=2245
-----------------------------------------------------------------------
 Ticket             | 2245
 Updated By         | Jan Schneider <jan at horde.org>
 Summary            | Horde Share implementation for Turba
 Queue              | Turba
 Version            | HEAD
 State              | Feedback
 Priority           | 1. Low
 Type               | Enhancement
 Owners             | Michael Rubinsky
-----------------------------------------------------------------------


Jan Schneider <jan at horde.org> (2005-07-29 02:37) wrote:

I didn't look closely at the code, so I can't say anything on the
implementation, but these are the issues I found at a quick glance:

1) There's too much logic in sources.php. This must be moved somewhere else,
maybe lib/base.php?
2) Don't assume an SQL preference backend in the migration script. Use the
Prefs API to update the preferences. Ah, now that I read it again, I see
that you're updating all users' preferences. Maybe this could be done like
the filter migration script in Ingo.
3) It would be great if you could use Turba's API to update the contact
owners, but I don't know without looking at the code, if this is possible.
This would allow using the script with different backends.
4) Make the source (and table, if not using Turba's API) configurable. Most
people are using localsql for private adress books.