[Tickets #2245] Horde Share implementation for Turba

[bugs@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: https://dev.horde.org/horde/whups/ticket/?id=2245
-----------------------------------------------------------------------
 Ticket             | 2245
 Updated By         | Michael Rubinsky <mrubinsk at horde.org>
 Summary            | Horde Share implementation for Turba
 Queue              | Turba
 Version            | HEAD
 State              | Feedback
 Priority           | 1. Low
 Type               | Enhancement
 Owners             | Michael Rubinsky
-----------------------------------------------------------------------


Michael Rubinsky <mrubinsk at horde.org> (2005-07-30 08:11) wrote:

> I'm no longer seeing
> multiple copies of my own address book, (i.e. one named My 
> Addressbook and another named Kevin Myer's Addressbook).

I was never able to reproduce this, but I'm glad it's fixed for you...

> For simplicity, I'd like to see the My Addressbooks screen pattern 
> the My {Calendars, Notes, Tasks} more, in the sense that those 
> screens have only one menu to choose the share that is being acted 
> on, then they have an Edit button, a description field, and a Save 
> and Delete button.  So you'd end up with a "Create Addressbook" and 
> "Edit Addressbook".

I'll can add the functionality to edit name and description and put that,
along with permissions, into an "Edit" drop down.  I seperated the delete
because I didn't want to present addressbooks that couldn't be deleted in a
drop down that included a delete button.  As it stands now, the delete
section is not shown if there are no removable addressbooks. I currently
don't allow the user's default addressbook for each source that supports
shares (right now, only sql) to be deleted.  I could be conviced that this
should be changed...anyone else have strong opinions one way or the other?

While we are on the topic of deletions, I *am* aware that the code, as it
stands now, does not actually delete the addressbook data itself, just the
share that points to it.  I'm trying to figure out the best way to do this. 
Probably going to have to add a $driver->deleteAddressbook or something
similar.  For SQL sources, it would just remove all the entries in the
turba_objects table that match the owner.  Maybe add this to the driver's
capabilities array?  Again, for some of the other types of sources, the
deletion can be done via the share hooks if needed.

> Also, a user isn't going to know much about the addressbook type.  I 
> can see confusion when their choices are localsql and none. 

Yep, already working on this, but wanted to get the core of the
functionality worked out first ;)