[Tickets #2799] NEW: IMP_Fetchmail_imap defaults never apply

[bugs@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=2799
-----------------------------------------------------------------------
 Ticket             | 2799
 Created By         | jwm at horde.net
 Summary            | IMP_Fetchmail_imap defaults never apply
 Queue              | IMP
 Version            | HEAD
 State              | Unconfirmed
 Priority           | 1. Low
 Type               | Bug
 Owners             | 
-----------------------------------------------------------------------


jwm at horde.net (2005-10-17 09:10) wrote:

IMP_Fetchmail_imap supplies defaults for {l,r}mailbox in its constructor:

    function IMP_Fetchmail_imap($params)
    {
        /* Default values for a couple of parameters. */
        $defaults = array(
            'rmailbox' => 'INBOX',
            'lmailbox' => 'INBOX'
        );
        $params = array_merge($defaults, $params);

but these values never apply because imp/fetchmailprefs.php unconditionally
sets all parameters:

    foreach ($fetchmail->getParameterList() as $val) {
        $fm_account->setValue($val, Util::getFormData('fm_' . $val),
$to_edit);
    }

so they wind up being empty strings ("").

Should IMP_Fetchmail_imap() override empty strings with the defaults? Does
having an empty value for {l,r}mailbox make any sense (IOW, do any remote
servers interpret this as a sane default)?