[Tickets #2871] NEW: messages not marked as 'personal'

[bugs@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=2871
-----------------------------------------------------------------------
 Ticket             | 2871
 Created By         | dgehl at inverse.ca
 Summary            | messages not marked as 'personal'
 Queue              | IMP
 Version            | 4.0.3
 State              | Unconfirmed
 Priority           | 2. Medium
 Type               | Bug
 Owners             | 
-----------------------------------------------------------------------


dgehl at inverse.ca (2005-10-26 17:03) wrote:

If a user decides to change it's 'from: address' to 
username <user at example.com>
instead of simply 
user at example.com
no messages are marked any more as 'personal' in mailbox.php and
message.php.

This problem could be solved by changing in imp/lib/Identity/imp.php the
getMatchingIdentity and hasAddress functions.

in getMatchingIdentity, instead of 
            /* Next, search all from addresses. */
            if (isset($own_addresses[$find_address])) {
                return $own_addresses[$find_address];
            }
we could use
            foreach (array_keys($own_addresses) as $current_address) {
                if (IMP::bareAddress($current_address) == $find_address)
{
                    return true;
                }
            }

and in hasAddress($address), instead of
//        return isset($list[$address]);
we could use
        foreach (array_keys($list) as $current_address) {
           if (IMP::bareAddress($current_address) == $address) {
                return true;
           }
        }
        return false;

I observed this in IMP 4.0.3, but after a look in the cvs, I have the
impression that it should also apply to all later versions (including cvs).