[Tickets #2999] NEW: PHP4.4 notice: Only variable references...

[bugs@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=2999
-----------------------------------------------------------------------
 Ticket             | 2999
 Created By         | jens at peino.de
 Summary            | PHP4.4 notice: Only variable references...
 Queue              | Horde Framework Packages
 Version            | HEAD
 State              | Unconfirmed
 Priority           | 1. Low
 Type               | Bug
 Owners             | 
-----------------------------------------------------------------------


jens at peino.de (2005-11-18 09:51) wrote:

Hello,

another php4.4 warning.

Possible patch below:


Index: framework/MIME/MIME/Structure.php
===================================================================
RCS file: /repository/framework/MIME/MIME/Structure.php,v
retrieving revision 1.93
diff -u -r1.93 Structure.php
--- framework/MIME/MIME/Structure.php   7 Nov 2005 15:34:26 -0000      
1.93
+++ framework/MIME/MIME/Structure.php   18 Nov 2005 17:46:10 -0000
@@ -292,13 +292,16 @@

         $mimeDecode = &new Mail_mimeDecode($text, MIME_PART_EOL);
         if (!($structure = $mimeDecode->decode($decode_args))) {
-            return false;
+            $mime_structure = false;
         }
+        else {
+            /* Put the object into imap_parsestructure() form. */
+            MIME_Structure::_convertMimeDecodeData($structure);

-        /* Put the object into imap_parsestructure() form. */
-        MIME_Structure::_convertMimeDecodeData($structure);
-
-        return MIME_Structure::parse($structure);
+            $mime_structure = MIME_Structure::parse($structure);
+        }
+
+        return $mime_structure;