[Tickets #3038] NEW: enscript output for diffs renders improperly

[bugs@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=3038
-----------------------------------------------------------------------
 Ticket             | 3038
 Created By         | kevin_myer at iu13.org
 Summary            | enscript output for diffs renders improperly
 Queue              | Horde Framework Packages
 Version            | HEAD
 State              | New
 Priority           | 1. Low
 Type               | Enhancement
 Owners             | 
+New Attachment     | MIME-enscript.patch
-----------------------------------------------------------------------


kevin_myer at iu13.org (2005-11-24 10:16) wrote:

The enscript driver, which is used to generate output for diffs and patches,
contains elements that cause the viewer to render poorly in different
browsers.

In Internet Explorer, if you view a patch/diff, the line numbers are
correct, but all text is rendered on the first line by IE.  If you send the
proper header, the text renders on the proper lines, except..

For any browser, the lines of text do not match up with the line numbers. 
For small patches, this is not a problem, because the cumulative offset of
the lines vs. the line numbers may not be that great.  But its noticeable in
larger patches.  After finally figuring out how this all works, it came down
to the fact that enscript adds bold and italic tags to the HTML it generates
(which is what its supposed to do).  However, those tags cause the
respective lines to render slightly larger.  So for that issue to be
resolved, the bold and italic tags need stripped.  The obvious tradeoff is
you lose bold for additions in a diff and italics for location line numbers.
 However, if you keep the bold and italics, the line numbers on the left are
pretty much useless.

I think this patch puts things into a more useful state - color syntax
highlighting is intact, and line numbers match, but at the expense of bold
and italics.