[Tickets #3474] block login for a given time span after x failed logins

bugs@bugs.horde.org bugs at bugs.horde.org
Tue Feb 21 03:02:58 PST 2006


DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=3474
-----------------------------------------------------------------------
 Ticket             | 3474
 Updated By         | tokoe at kde.org
 Summary            | block login for a given time span after x failed logins
 Queue              | Kolab
 State              | Feedback
 Priority           | 2. Medium
 Type               | Enhancement
 Owners             | 
+New Attachment     | feature_block_login.patch
-----------------------------------------------------------------------


tokoe at kde.org (2006-02-21 03:02) wrote:

Hi,

here is the third revision ;)

> A few more comments:
> - The patch to conf.xml is missing
fixed

> - You assign $history_data, but never use it
fixed

> - You loop through $history_log->getData() but overwrite 
> $history_list each time inside the loop
using array_shift now

> - You could use getByTimestamp()  to get the number of failed logins 
> during the configured time span in one go
To complicated, left the code as it is

> - You never delete the history entries (when you have successful 
> logins), which will fill up the history table with every failed login
Only the relevant timestamps are copied into $new_login_history, so
the history will always be around 5 entries, not more.

Ciao,
Tobias





More information about the bugs mailing list