[Tickets #3533] NEW: two problems with link attachments

[bugs@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=3533
-----------------------------------------------------------------------
 Ticket             | 3533
 Created By         | Eric Rostetter <eric.rostetter at physics.utexas.edu>
 Summary            | two problems with link attachments
 Queue              | IMP
 Version            | RELENG_3
 State              | Unconfirmed
 Priority           | 2. Medium
 Type               | Bug
 Owners             | 
-----------------------------------------------------------------------


Eric Rostetter <eric.rostetter at physics.utexas.edu> (2006-02-24 21:10) wrote:

Running current CVS FRAMEWORK_3 code of Horde/IMP/etc, when trying to
compose
messages with attachments and have the attachments sent as links, I have the
following
two problems.  Note: running PHP 4.3.2 which may or may not be relevent, and
using
the "file" VFS for composing with attachments, and for storing the
attachments for the
links.

First, the attachment is correctly in <tempdir>/.horde/imp/compose/ when
composing.
But when the message is sent, the code is supposed to move/rename it to
<tempdir>/.horde/imp/attachments/<user>/<timestamp> but this only works if
<tempdir>/.horde/imp/attachments/<user> already exists.  If not, it silently
fails
without any notice/error/etc.  I've "fixed" this in my version with a
homemade patch
where I do a recursive mkdir() on the path before trying to vfs->rename()
the
file to it in imp/lib/Compose.php.  I can supply my local patch if
requested.

Second,  if notification is enabled for the links, such that you are
e-mailed when
the link is viewed, it is sending to the username only (since my users login
with
the username only) and not the full username+domain.  Since my webmail is
behind a load-balancing front-end with no hostname, this ends up trying to
send to user at 172.16.78.23 instead of to user at mydomain.  I've locally
patched
this to just append the domain name in imp/attachments.php, which obviously
isn't right.  I'm thinking the best way to "fix" this might be to provide a
hook for
use in attachments.php for how to modify the user?  No patch for this
one...
This probably is an edge case for people like me (login without
realm/domain,
web server has a private IP and no DNS for it, sendmail on web server isn't
configured to correctly convert IP to something else _yet_ but will be soon,
etc).