[Tickets #3541] RESOLVED: Improper regular expressions for matching addresses in Horde/UI/VarRenderer/html.php

bugs@bugs.horde.org bugs at bugs.horde.org
Thu Mar 2 09:31:59 PST 2006


DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=3541
-----------------------------------------------------------------------
 Ticket             | 3541
 Updated By         | Chuck Hagenbuch <chuck at horde.org>
 Summary            | Improper regular expressions for matching addresses in Horde/UI/VarRenderer/html.php
 Queue              | Horde Base
 Version            | 3.1-RC3
-State              | Unconfirmed
+State              | Resolved
 Priority           | 1. Low
 Type               | Bug
 Owners             | 
-----------------------------------------------------------------------


Chuck Hagenbuch <chuck at horde.org> (2006-03-02 09:31) wrote:

> "USA", ie. US American addresses. I think that the regex should check 
> for word boundaries: \b(ACT|NSW|NT|QLD|SA|TAS|VIC|WA)\b. Possibly, 
> the regex for UK addresses should also be updated.

I've added the word boundary checks, thanks.

> BTW, what about adding comments with example addresses that show 
> what address style these regular expressions are supposed to match?

Sounds good. If you could submit a patch for it that'd be great. If you're
not quite up to a patch, you could start a small wiki page - probably under
the developer docs, http://wiki.horde.org/Doc/Dev - with notes on the code.




More information about the bugs mailing list