[Tickets #3588] NEW: can't add entries when only one source is editable

[bugs@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=3588
-----------------------------------------------------------------------
 Ticket             | 3588
 Created By         | matthew.dunham at ic.ucsb.edu
 Summary            | can't add entries when only one source is editable
 Queue              | Turba
 Version            | 2.1
 State              | Unconfirmed
 Priority           | 1. Low
 Type               | Bug
 Owners             | 
-----------------------------------------------------------------------


matthew.dunham at ic.ucsb.edu (2006-03-08 17:55) wrote:

in lib/base.php, the following code has a small bug:

    // Hide the list of addressbooks if there is only one available. 
    $add_source_options = '';
    $addSources = Turba::getAddressBooks(PERMS_EDIT);
    if (count($addSources) > 1) {

this conditional expression is true only if you have at least 2 editable
sources, which neither agrees with the comment nor the logic. e.g. in the
case where you want to, say, copy an entry from an readonly source to a
readwrite source, this condition fails. 

        if (count($addSources) > 0) {

is the appropriate fix.