[Tickets #3731] Currencies and Taxes

[bugs@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=3731
-----------------------------------------------------------------------
 Ticket             | 3731
 Updated By         | duck at obala.net
 Summary            | Currencies and Taxes
 Queue              | Horde Base
 Version            | HEAD
 State              | New
 Priority           | 1. Low
 Type               | Enhancement
 Owners             | 
-----------------------------------------------------------------------


duck at obala.net (2006-05-04 01:33) wrote:

>> I still dont understand RDO::update call good.
> Can you say what about it doesn't make sense?

I found it. The RDO_Mapper::update has the optional second parameter
"fields". But is when instance of RDO is passed as an object this is
ignored. I guess we should check if it is null. 

@ -212,9 +212,7 @@
         if ($object instanceof RDO) {
             $key = $this->describe()->key;
             $id = $object->$key;
-            if (is_null($fields)) {
-                $fields = $object->getFields();
-            }
+            $fields = $object->getFields();
         } else {
             $id = $object;
         }