[Tickets #4191] NEW: API contains invalid SOAP data types

[bugs@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: https://dev.horde.org/horde/whups/ticket/?id=4191
-----------------------------------------------------------------------
 Ticket             | 4191
 Created By         | Ben Klang <ben at alkaloid.net>
 Summary            | API contains invalid SOAP data types
 Queue              | Ansel
 State              | Unconfirmed
 Priority           | 1. Low
 Type               | Bug
 Owners             | 
+New Attachment     | ansel-soap-api-type.patch
-----------------------------------------------------------------------


Ben Klang <ben at alkaloid.net> (2006-07-22 21:36) wrote:

This patch brings the argument and type data types in line with what is
required for SOAP.  Exception: Any method which either accepts or returns
an object or resource.  These are invalid for SOAP as far as I know and
should probably be somehow excluded from the WSDL.  Kronolith in
particular alread has these marked with FIXME, but Ansel also incorporates
a method (createGallery()) with an 'object' argument.

One other note for this patch:  The datatype for countGalleries()
overloads the attributes argument to either be a string or a an array of
attributes (attribute => value).  Since SOAP can't overload the types, I
have set it to {urn:horde}mixed.  This may be an issue if someone wants to
call countGalleries() using a userID string for the attribute argument. 
Fixing it will likely break BC though so I leave it to the maintainer to
decide how to proceed.