[Tickets #4299] Unquoted signature no longer dim

[bugs@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: https://dev.horde.org/horde/whups/ticket/?id=4299
-----------------------------------------------------------------------
 Ticket             | 4299
 Updated By         | Michael Slusarz <slusarz at horde.org>
 Summary            | Unquoted signature no longer dim
 Queue              | Horde Framework Packages
 Version            | HEAD
 Type               | Bug
 State              | Assigned
-Priority           | 1. Low
+Priority           | 2. Medium
 Owners             | Michael Slusarz
-----------------------------------------------------------------------


Michael Slusarz <slusarz at horde.org> (2006-08-17 07:34) wrote:

Your issue is bogus.  The algorithim for dimming signatures recently
changed from dimming everything below the first signature line to dimming
everything below the last signature line.  It has nothing to do with
quoted vs. unquoted.  The new algorithim makes more sense because it won't
result in an entire message being dimmed if the signature appears on top. 
Not to start a holy war, but it is definitely preferred etiquette to quote
under previous text, so the user's signature should *always* appear at the
bottom of the message.

However, your message does bring up another issue - namely, we shouldn't
be dimming signatures in quoted text anyway if just for the simple fact we
start mixing closed/unclosed div/span tags and the page won't render
properly.  i.e., in this case, pseudocode looks like this:

<div class="quoted1">
<div class="quoted2">
 HTML
<span class="signature">
 Signature
</div>
</div>
</span>

This is a severe limitation with the current Text_Filter scheme since each
filter doesn't (and can't) know if a previous filter has inserted div/span
tags that may intersect the current text.  Yuck.

Possible solution - we have to do signature dimming in the highlight quote
filter.  This would ensure we weren't setting a signature span across
quoted div's.