[Tickets #4352] NEW: Refactor factory() methods

[bugs@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: https://dev.horde.org/horde/whups/ticket/?id=4352
-----------------------------------------------------------------------
 Ticket             | 4352
 Created By         | Chuck Hagenbuch <chuck at horde.org>
 Summary            | Refactor factory() methods
 Queue              | Horde Framework Packages
 Version            | HEAD
 Type               | Enhancement
 State              | Assigned
 Priority           | 1. Low
 Owners             | Chuck Hagenbuch
-----------------------------------------------------------------------


Chuck Hagenbuch <chuck at horde.org> (2006-08-28 13:40) wrote:

Some factory methods have already been refactored to check for class_exists
so that custom classes can simply be included before calling the factory.
Remove $app array parameters if not used. Once we always check for
class_exists() first, no need for include_once/require_once - just use
include. Always use include instead of require unless a factory getting
invalid parameters should really be a fatal error (pretty much never
should). Remove & from factory methods where BC.

Also, replace singletons that don't need to be singletons (most of them)
with bare wrappers around factory() and deprecate the singleton() calls.
Remove outright if they're not used.