[Tickets #4489] NEW: More "only variable references should be returned by reference" problems

[bugs@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: https://dev.horde.org/horde/whups/ticket/?id=4489
-----------------------------------------------------------------------
 Ticket             | 4489
 Created By         | Matt Selsky <selsky at columbia.edu>
 Summary            | More "only variable references should be returned by reference" problems
 Queue              | Horde Framework Packages
 Version            | HEAD
 Type               | Bug
 State              | Accepted
 Priority           | 1. Low
 Owners             | 
-----------------------------------------------------------------------


Matt Selsky <selsky at columbia.edu> (2006-10-05 00:50) wrote:

The following functions have problems with "only variable references should
be returned by reference" since they return false on error instead of
returning $false.

framework/iCalendar/iCalendar.php:

&findComponent()
&findComponentByAttribute()

framework/IMAP/IMAP/Tree.php:

&_getStream()

framework/Kolab/Kolab.php:

&loadObject()
&newObject()
&getElem()

framework/MIME/MIME/Headers.php:

&_getStream()

framework/MIME/MIME/Viewer.php:

&factory()

ingo/lib/Ingo.php:

&loadIngoScript()

sesha/lib/Driver.php:

&factory()

Perhaps some of the functions don't need to return references at all.