[Tickets #4602] Re: patch for maintenance

[bugs@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=4602
-----------------------------------------------------------------------
 Ticket             | 4602
 Updated By         | Michael Slusarz <slusarz at horde.org>
 Summary            | patch for maintenance
 Queue              | Horde Framework Packages
 Version            | HEAD
 Type               | Bug
-State              | Assigned
+State              | Feedback
 Priority           | 1. Low
 Owners             | Michael Slusarz
-----------------------------------------------------------------------


Michael Slusarz <slusarz at horde.org> (2006-11-02 21:56) wrote:

This doesn't look right.  What is happening I think is this - the redirect
URL is something like:
  foo.php?foo1=bar1&amp;app=imp

Then we add another parameter via addParameter() so the redirect URL looks
like this:
  foo.php?foo1=bar1&amp;app=imp&foo2=bar2

So we are mixing and matching &amp; and & because addParameter() doesn't
recognize we are already using &amp; in the query string.  And we can't
encode all &'s as &amp's, as your patch does, since this won't work with
the Redirect calls in some browsers.

So what I have done is rewritten addParameter() to auto detect the current
delimiter and deal with it in a consistent manner.  So feedback on this
change is needed to see if that fixes this issue.