[Tickets #4640] passwd_expect patch

[bugs@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=4640
-----------------------------------------------------------------------
 Ticket             | 4640
 Created By         | asuffield at suffields.me.uk
 Summary            | passwd_expect patch
 Queue              | Passwd
 Version            | HEAD
 Type               | Bug
 State              | Unconfirmed
 Priority           | 1. Low
 Owners             | 
+New Attachment     | passwd_expect.diff
-----------------------------------------------------------------------


asuffield at suffields.me.uk (2006-11-09 04:41) wrote:

The attached patch was required for me to get passwd_expect to work
correctly.

I cannot explain why stdin might be in non-blocking mode, but it was,
and so sometimes expect would miss the username/password strings. I
can only put this one down to deep crackfulness on the part of tcl,
expect, apache, or php, and express my strong desire to never know
what is going on there. Understanding this can only lead to
pain. Forcing stdin into blocking mode ensures that it always works.

The exp_continue is necessary because otherwise, if expect sees
$fingerprint_string, it does not bother looking for $password_string
or sending the old password. Obviously nobody ever tested this, it
can't ever have worked.