[Tickets #4062] Re: Kolab.php compatibility with php5

[bugs@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=4062
-----------------------------------------------------------------------
 Ticket             | 4062
 Updated By         | wrobel at gentoo.org
 Summary            | Kolab.php compatibility with php5
 Queue              | Kolab
 Type               | Bug
 State              | Feedback
 Priority           | 2. Medium
 Owners             | 
-----------------------------------------------------------------------


wrobel at gentoo.org (2006-11-14 01:58) wrote:

>> It adds a number of additional functions from
>>
http://alexandre.alapetite.net/doc-alex/domxml-php4-php5/domxml-php4-to-php5.php.txt
that are needed 
>> by
>> Kolab.php.
>
> Please document that including author, license, conditions etc. in 
> the file header.

As mentioned in the header of DOM.php the whole file has been derived from
this original script. Both the author and the source url are mentioned in
there. I don't know if DOM.php was derived from a very early version of
that original script or if the original version only included the
functions that were necessary for horde at that time.

The current version of the script from Alexandre Alapetite contains a
number of additional functions not provided by DOM.php at the moment. I
did only transfer those additional functions that are needed by
Kolab.php.

> Yes, with one exception: if-clauses must always use curly braces.

Fixed. See attachement.