[Tickets #4703] Re: response message - partial bad coding

[bugs@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=4703
-----------------------------------------------------------------------
 Ticket             | 4703
 Updated By         | Jan Schneider <jan at horde.org>
 Summary            | response message - partial bad coding
 Queue              | IMP
 Version            | 4.1.3
 Type               | Bug
 State              | Assigned
 Priority           | 2. Medium
-Owners             | Michael Slusarz, Jan Schneider
+Owners             | Michael Slusarz, Jan Schneider
-----------------------------------------------------------------------


Jan Schneider <jan at horde.org> (2006-12-05 02:49) wrote:

>> This still needs to be done in HEAD. I looked at it, but the place to
>> get the old part's charset is moved around in HEAD, and I'm not clear
>
> I think what needs to be done is to save the browser charset at the 
> time we save 'attrib_text' so we know how to convert the text when 
> creating the message (i.e. via a 'attrib_text_charset' implicit pref 
> set in a prefs callback).  As of right now, there is no way of 
> knowing what charset 'attrib_text' is when we try to convert 
> (definitely no guarantee NLS::getCharset() is the correct charset).

Of course there is. The preference value is converted from browser charset
to backend charset when saving the pref and vice versa when loading the
pref. The text should always be encoded in  NLS::getCharset().