[Tickets #4751] Explicitely put 'CLASS: PUBLIC' in VEVENT to avoid Outlook error

[bugs@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=4751
-----------------------------------------------------------------------
 Ticket             | 4751
 Created By         | steven.deboeck at excentis.com
 Summary            | Explicitely put 'CLASS: PUBLIC' in VEVENT to avoid Outlook error
 Queue              | Kronolith
 Version            | HEAD
 Type               | Enhancement
 State              | New
 Priority           | 1. Low
 Owners             | 
+New Attachment     | kronolith_lib_driver.patch
-----------------------------------------------------------------------


steven.deboeck at excentis.com (2006-12-07 06:59) wrote:

Hi all,


I'm testing the synchronisation of Kronolith with Outlook2000 + Funambol
Outlook Plug-in 3.0.15. One of the little problems I ran into was the
following:
1) Create a private event in Outlook.
2) Sync the calendar with Kronolith.
3) Remove the private flag in Kronolith.
4) Sync again.
Result: event in Outlook still has private flag.

I looked into the syncml logs and saw that Outlook always puts a CLASS
property in a VEVENT (either set to PUBLIC or PRIVATE), while Kronolith
only puts a CLASS property in a VEVENT if the value is PRIVATE.
I'm pretty sure Kronolith's behaviour is correct, since the iCal spec
(rfc2445) clearly states that the default value for the CLASS property is
PUBLIC. However, Outlook or the Funambol client don't change the value if
it's not present, so I changed kronolith/lib/Driver.php to always put a
CLASS property in a VEVENT.

I've attached the patch, it's just two extra lines. I'd understand if this
isn't incorporated in the code, since Kronolith does nothing wrong, but I'd
appreciate it if it could be added. Always adding the CLASS property isn't
wrong either and it makes the synchronisation between Outlook and
Kronolith work a little better.


Best regards,

Steven

P.S. Since this is my first contribution, let me know if I goofed up the
patch file.