[Tickets #4797] Re: A large horde_vfs table can cause large memory usage during GC

[bugs@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=4797
-----------------------------------------------------------------------
 Ticket             | 4797
 Updated By         | Chuck Hagenbuch <chuck at horde.org>
 Summary            | A large horde_vfs table can cause large memory usage during GC
 Queue              | Horde Framework Packages
 Version            | HEAD
 Type               | Bug
-State              | Feedback
+State              | Resolved
 Priority           | 2. Medium
 Owners             | 
-----------------------------------------------------------------------


Chuck Hagenbuch <chuck at horde.org> (2006-12-21 10:48) wrote:

> I was able to get it to work, with two small changes.
>
> 1) Make the first line of the function be '$conn = $this->_connect();'
> 2) Change '$this->_write_db' to be '$this->db'

This means you are not using HEAD, and in fact you're not even using the
latest FW_3 code. VFS_sql was changed a while ago to not load the body of
every file in the _listFolder() method (it uses the db server to get the
file sizes instead), which is probably what's driving up your memory usage
anyway. I'll keep the changes, but you should really update.

> A couple other comments, I notice a lot of the other functions use 
> $this->_db->quote(), but this one doesn't. 

It uses a prepared statement (the ? placeholders).

> Also, will there be a similar function put in place for sql_file?

That'd have to do filesystem operations anyway - not nearly as much of a
speed/efficiency increase. I'd probably accept a patch for one though.