[Tickets #4890] preferences: use_trash disables delhide

[bugs@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=4890
-----------------------------------------------------------------------
 Ticket             | 4890
 Created By         | 406728 at bugs.debian.org
 Summary            | preferences: use_trash disables delhide
 Queue              | IMP
 Version            | 4.1.3
 Type               | Bug
 State              | Unconfirmed
 Priority           | 1. Low
 Owners             | 
-----------------------------------------------------------------------


406728 at bugs.debian.org (2007-01-13 22:56) wrote:

When the use_trash preference is enabled, the value of the delhide
preference is ignored and effectively forced off. Didn't you mean on the
contrary to force it *on* when use_trash is on?

That is, replace in lib/Mailbox.php:

            $this->_delhide = ($GLOBALS['prefs']->getValue('delhide') &&
                               !$GLOBALS['prefs']->getValue('use_trash')
&&
                               ($GLOBALS['imp_search']->isSearchMbox() ||
                               ($GLOBALS['prefs']->getValue('sortby') !=
SORTTHREAD)));

by

            $this->_delhide = (($GLOBALS['prefs']->getValue('delhide') ||
                               !$GLOBALS['prefs']->getValue('use_trash'))
&&
                               ($GLOBALS['imp_search']->isSearchMbox() ||
                               ($GLOBALS['prefs']->getValue('sortby') !=
SORTTHREAD)));