[Tickets #4901] missing x-header causes spamassassin hit

[bugs@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=4901
-----------------------------------------------------------------------
 Ticket             | 4901
 Created By         | kevin at ualberta.net
 Summary            | missing x-header causes spamassassin hit
 Queue              | IMP
 Version            | 3.2.3
 Type               | Enhancement
 State              | New
 Priority           | 1. Low
 Owners             | 
-----------------------------------------------------------------------


kevin at ualberta.net (2007-01-15 13:59) wrote:

In /imp/compose.php, line 987 you have the following:

  /* Add the X-Priority header, if requested. This appears here since
       this is the "general" location that other mail clients insert
       this header. */
    if ($prefs->getValue('set_priority') &&
        Util::getFormData('x_priority')) {
        $msg_headers->addHeader('X-Priority',
Util::getFormData('x_priority'));
    }


That's great except if you don't also add an X-Mailer header, Spamassassin
complains:

X-Spam-Checker-Version: SpamAssassin 2.64 (2004-01-11) on 
	mailg.srv.ualberta.ca
X-Spam-Level: 
X-Spam-Status: No, hits=-98.8 required=2.0
tests=BAYES_00,PRIORITY_NO_NAME,
	USER_IN_WHITELIST autolearn=no version=2.64
X-Spam-Report: 
	*  1.2 PRIORITY_NO_NAME Message has priority setting, but no X-Mailer

I've done a little hack which just adds an X-Mailer header after the
X-Priority and it solves the problem.  Perhaps it should be there by
default if IMP is going to add a priority?