[Tickets #4928] Re: Combine "Tickets which are" and "Type" selects in Search form

[bugs@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=4928
-----------------------------------------------------------------------
 Ticket             | 4928
 Updated By         | php at ideacode.com
 Summary            | Combine "Tickets which are" and "Type" selects in Search form
 Queue              | Whups
 Type               | Enhancement
 State              | Feedback
 Priority           | 1. Low
 Owners             | 
+New Attachment     | ss4928.jpg
-----------------------------------------------------------------------


php at ideacode.com (2007-02-02 19:35) wrote:

> This patch is not against current CVS, and can you please make it a 
> unified diff so it's easier to read? Thanks.

I will provide a unified diff.

Before doing so, I'd like to finish the changes.  My question is: how can
I render a table of multienums in a single row?  In the attached
screenshot, you can see that the 4 ticket types we have (Bug, Enhancement,
Question, and Task) are each in their own row.  I would prefer to render
these multienums horizontally (perhaps in a grid if the number of types
exceeds a threshold), but I couldn't figure out how to do that without
breaching the abstraction offered by Horde_Form.  Thoughts?

Also, you will notice that I have refactored the code -- the functional
units as they stood were too broad for me to make surgical changes and
have any confidence that they worked (at least not without substantial
unit tests, which I couldn't find).