[Tickets #4928] Re: Combine "Tickets which are" and "Type" selects in Search form

[bugs@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=4928
-----------------------------------------------------------------------
 Ticket             | 4928
 Updated By         | Chuck Hagenbuch <chuck at horde.org>
 Summary            | Combine "Tickets which are" and "Type" selects in Search form
 Queue              | Whups
 Type               | Enhancement
 State              | Feedback
 Priority           | 1. Low
 Owners             | 
-----------------------------------------------------------------------


Chuck Hagenbuch <chuck at horde.org> (2007-02-02 19:59) wrote:

> I will provide a unified diff.

Great, thank you.

> Before doing so, I'd like to finish the changes.  My question is: how 
> can I render a table of multienums in a single row?

You're going to need to write a custom form renderer. It doesn't have to
be fancy, just override creation of a separate table row for each input.
(I'll get into more detail if you need, but there are some around in whups
- queries - and other apps.)

> Also, you will notice that I have refactored the code -- the 
> functional units as they stood were too broad for me to make surgical 
> changes and have any confidence that they worked (at least not 
> without substantial unit tests, which I couldn't find).

I wasn't able to entirely follow the diff since it wasn't against HEAD,
but yeah, that's likely fine. Feel free to add those unit tests. :)